Skip to content

Backport PR #42318: PERF/REGR: symmetric_difference revert most of #41833 #42324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2021
Merged

Backport PR #42318: PERF/REGR: symmetric_difference revert most of #41833 #42324

merged 3 commits into from
Jun 30, 2021

Conversation

simonjayhawkins
Copy link
Member

Backport PR #42318

@simonjayhawkins simonjayhawkins added Performance Memory or execution speed performance setops union, intersection, difference, symmetric_difference labels Jun 30, 2021
@simonjayhawkins simonjayhawkins added this to the 1.3 milestone Jun 30, 2021
@simonjayhawkins
Copy link
Member Author

xref #42318 (comment)

       before           after         ratio
     [f34376d1]       [ea963bf8]
     <1.3.x>          <backport-of-pr-42318-on-1.3.x>
-      83.0±0.6ms       48.0±0.2ms     0.58  multiindex_object.SetOperations.time_operation('monotonic', 'string', 'symmetric_difference')
-      1.11±0.01s         643±10ms     0.58  multiindex_object.SetOperations.time_operation('monotonic', 'datetime', 'symmetric_difference')
-      83.5±0.8ms       47.8±0.6ms     0.57  multiindex_object.SetOperations.time_operation('non_monotonic', 'string', 'symmetric_difference')
-       102±0.9ms       58.1±0.4ms     0.57  multiindex_object.SetOperations.time_operation('non_monotonic', 'int', 'symmetric_difference')
-       103±0.4ms       58.2±0.8ms     0.57  multiindex_object.SetOperations.time_operation('monotonic', 'int', 'symmetric_difference')
-      1.14±0.01s          643±3ms     0.56  multiindex_object.SetOperations.time_operation('non_monotonic', 'datetime', 'symmetric_difference')
-      7.14±0.1ms      3.97±0.08ms     0.56  index_object.SetOperations.time_operation('datetime', 'symmetric_difference')
-      5.18±0.1ms      2.85±0.04ms     0.55  index_object.SetOperations.time_operation('int', 'symmetric_difference')
-      30.4±0.6ms       16.0±0.4ms     0.53  index_object.SetOperations.time_operation('date_string', 'symmetric_difference')
-      28.7±0.4ms       14.7±0.2ms     0.51  index_object.SetOperations.time_operation('strings', 'symmetric_difference')

SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY.
PERFORMANCE INCREASED.

jbrockmendel
jbrockmendel approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pre-caffeine, but this looks identical to the reversion I did last night (with an extra cast), in which case LGTM.

@simonjayhawkins
Copy link
Member Author

removed MultiIndex symmetric_difference also

@jbrockmendel
Copy link
Member

removed MultiIndex symmetric_difference also

Huh, i thought i had done that in the other one. LGTM.

@simonjayhawkins simonjayhawkins merged commit 061642a into pandas-dev:1.3.x Jun 30, 2021
@simonjayhawkins simonjayhawkins deleted the backport-of-pr-42318-on-1.3.x branch June 30, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

Assignees
No one assigned
Labels
Performance Memory or execution speed performance setops union, intersection, difference, symmetric_difference
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@simonjayhawkins @jbrockmendel